Indent <hr> properly for notification frequency when editing alerts #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@c03a7a0 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@skateman Looks fine |
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
Indent <hr> properly for notification frequency when editing alerts (cherry picked from commit 98380cf) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating/editing an alert under
Control -> Explorer -> Alerts, there is a special case when the notification frequency triggers the visibility of some extra items. After each part of the form there's a<hr>and the one related to the extra items was not indented properly.Before:
After:
@miq-bot add_label formatting/styling, bug, gaprindashvili/yes
@miq-bot assign @epwinchell
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1523281