Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spinner when item in gtl is clicked and has showUrl #3117

Merged
merged 1 commit into from Dec 20, 2017
Merged

Add spinner when item in gtl is clicked and has showUrl #3117

merged 1 commit into from Dec 20, 2017

Conversation

ZitaNemeckova
Copy link
Contributor

Compute -> Infrastructure -> Virtual Machines -> click one of them or any other GTL

Before:

Redirected without spinner

screen shot 2017-12-20 at 1 04 54 pm

After:

Redirected with a spinner

screen shot 2017-12-20 at 12 57 39 pm

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1500506
@miq-bot add_label blocker, gaprindashvili/yes, bug, gtls

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

Checked commit ZitaNemeckova@41e3cd3 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@dclarizio dclarizio self-assigned this Dec 20, 2017
@himdel
Copy link
Contributor

himdel commented Dec 20, 2017 •
edited

LGTM :) .. tested in UI:

  • Pages where clicking on the url goes to a different screen 👍
  • Random explorer screens (with ajaxy reloads, needs spinnerOff somewhere) 👍
  • Explorer screens which do tree_select (ops rbac) 👍
  • GTL in detail/form (not clickable) 👍 (well, looks like they all are clickable, but that's a separate bug ([WIP] Disable click on tag edit screens #1568))

(also, confirmed that g/t/l behave the same, as does clicking the url vs clicking the quad)

@himdel himdel added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 20, 2017
@himdel himdel merged commit d2810f1 into ManageIQ:master Dec 20, 2017
simaishi pushed a commit that referenced this pull request Jan 3, 2018
@himdel @simaishi
Merge pull request #3117 from ZitaNemeckova/add_spinner
c8d656a 
Add spinner when item in gtl is clicked and has showUrl
(cherry picked from commit d2810f1)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530767
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit c8d656a44074d209fe77391ddb483b3c347ca105
Author: Martin Hradil <himdel@seznam.cz>
Date:   Wed Dec 20 17:37:00 2017 +0100

    Merge pull request #3117 from ZitaNemeckova/add_spinner
    
    Add spinner when item in gtl is clicked and has showUrl
    (cherry picked from commit d2810f12ed5056f9f9f8ba1f4241c8cf5226a836)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530767

@ZitaNemeckova ZitaNemeckova deleted the add_spinner branch January 8, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel Awaiting requested review from himdel

Assignees

@dclarizio dclarizio

Labels
blocker bug gaprindashvili/backported gtls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZitaNemeckova @miq-bot @himdel @simaishi @dclarizio