Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AZURE] Make region selection mandatory before validation #3125

Merged
merged 1 commit into from Dec 21, 2017
Merged

[AZURE] Make region selection mandatory before validation #3125

merged 1 commit into from Dec 21, 2017

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented Dec 20, 2017 •
edited

This makes region selection mandatory before validation when adding a new Azure provider.

Partially addresses https://bugzilla.redhat.com/show_bug.cgi?id=1515670

There will also be a backend warning added in the Azure provider repo itself.

Thanks go to @AparnaKarve for helping me with this. And by "help" I mean giving me the answer. ;)

@bronaghs
Copy link

@miq-bot assign @AparnaKarve

bronaghs
bronaghs approved these changes Dec 20, 2017
View reviewed changes
Copy link

@bronaghs bronaghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a Provider perspective.

@djberg96 djberg96 mentioned this pull request Dec 20, 2017
Merged
@djberg96
Copy link
Contributor Author

Not much I can do about those Scrutinizer or codeclimate issues. Just following the existing pattern.

@AparnaKarve
Copy link
Contributor

AparnaKarve commented Dec 20, 2017 •
edited

Not much I can do about those Scrutinizer or codeclimate issues. Just following the existing pattern.

@djberg96 Agree.

@h-kataria This is good to go.

@djberg96 Lets fix the Edit form to address the TypeError: Cannot read property '$valid' of undefined error which occurs because the Region field in now read-only

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

Checked commit https://github.com/djberg96/manageiq-ui-classic/commit/5414e5359a5c7c6e712d2c725c0ee1d195288c00 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@AparnaKarve
Copy link
Contributor

@h-kataria LGTM now

@dclarizio dclarizio merged commit fde59e5 into ManageIQ:master Dec 21, 2017
@dclarizio dclarizio added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 21, 2017
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit ba616078413360bf08450576a2deb987c69166c4
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Thu Dec 21 13:43:53 2017 -0800

    Merge pull request #3125 from djberg96/azure_mandatory_region
    
    [AZURE] Make region selection mandatory before validation
    (cherry picked from commit fde59e52bf7aea86eb8466978c5954535ee32c3a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1530731

simaishi pushed a commit that referenced this pull request Jan 3, 2018
@simaishi
Merge pull request #3125 from djberg96/azure_mandatory_region
ba61607 
[AZURE] Make region selection mandatory before validation
(cherry picked from commit fde59e5)

https://bugzilla.redhat.com/show_bug.cgi?id=1530731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bronaghs bronaghs bronaghs approved these changes

Assignees
No one assigned
Labels
bug compute/cloud gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@djberg96 @bronaghs @AparnaKarve @miq-bot @simaishi @dclarizio