Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ldap_region_delete to whitelist in ops_controller #3136

Merged
merged 1 commit into from Dec 23, 2017
Merged

Add missing ldap_region_delete to whitelist in ops_controller #3136

merged 1 commit into from Dec 23, 2017

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Dec 22, 2017 •
edited

Resolves issue with #2942

Product feature must be set. Have new_ldap: true for product in current server Advanced.
Add LDAP authentication for any server.
Restart server.
Configuration -> Settings -> LDAP -> select any Region/Domain -> Configuration -> Delete
screen shot 2017-12-22 at 2 45 03 pm

Before:

F, [2017-12-22T14:28:10.772374 #39186] FATAL -- : Error caught: [ActionController::RoutingError] invalid button action
/Users/zita/Desktop/ManageIQ/manageiq-ui-
classic/app/controllers/application_controller/explorer.rb:196:in `generic_x_button'
/Users/zita/Desktop/ManageIQ/manageiq-ui-classic/app/controllers/ops_controller.rb:95:in `x_button'

After:
screen shot 2017-12-22 at 2 38 18 pm

cc: @jvlcek (LDAP)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530567

@miq-bot add_label settings, bug

@himdel himdel mentioned this pull request Dec 22, 2017
Closed
@miq-bot
Copy link
Member

miq-bot commented Dec 22, 2017

Checked commit ZitaNemeckova@d2f9744 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@martinpovolny martinpovolny merged commit 86b535f into ManageIQ:master Dec 23, 2017
@martinpovolny martinpovolny self-assigned this Dec 23, 2017
@martinpovolny
Copy link

@ZitaNemeckova, @jvlcek : I guess we need a BZ for this. Can you, please, create one?

@martinpovolny martinpovolny added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 23, 2017
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label bugzilla needed

simaishi pushed a commit that referenced this pull request Jan 3, 2018
@simaishi
Merge pull request #3136 from ZitaNemeckova/add_ldap_region_delete
229007a 
Add missing ldap_region_delete to whitelist in ops_controller
(cherry picked from commit 86b535f)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530791
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 229007aab86d227d29575aa1f5235f6ccfbcf767
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Sat Dec 23 18:21:47 2017 +0100

    Merge pull request #3136 from ZitaNemeckova/add_ldap_region_delete
    
    Add missing ldap_region_delete to whitelist in ops_controller
    (cherry picked from commit 86b535f749a41309ad299015ed03208f6f5c956a)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530791

@ZitaNemeckova ZitaNemeckova deleted the add_ldap_region_delete branch January 8, 2018 20:36
@Fryguy
Copy link
Member

Fryguy commented Jan 24, 2018

The setting is new_ldap not ldap_new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug gaprindashvili/backported settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZitaNemeckova @miq-bot @martinpovolny @simaishi @Fryguy