Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missed send_check to cloud network toolbars #3162

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jan 4, 2018

reproducer:
bvnomitdtc

@miq-bot assign @himdel

@miq-bot miq-bot added the wip label Jan 4, 2018
@lpichler lpichler changed the title [WIP] Adding missed send_check Adding missed send_check to cloud network toolbars Jan 4, 2018
@miq-bot miq-bot removed the wip label Jan 4, 2018
@lpichler
Copy link
Contributor Author

lpichler commented Jan 4, 2018

@miq-bot add_label grapridashvili/yes,bug

@miq-bot
Copy link
Member

miq-bot commented Jan 4, 2018

@lpichler Cannot apply the following label because they are not recognized: grapridashvili/yes

@himdel
Copy link
Contributor

himdel commented Jan 4, 2018

LGTM, this one was missed in #2398 :)

Looks like theres 3 more places missing send_checked, can you add it there too please?

diff --git a/app/helpers/application_helper/toolbar/cloud_networks_center.rb b/app/helpers/application_helper/toolbar/cloud_networks_center.rb
index 12b5ca3680..626bad7394 100644
--- a/app/helpers/application_helper/toolbar/cloud_networks_center.rb
+++ b/app/helpers/application_helper/toolbar/cloud_networks_center.rb
@@ -22,6 +22,7 @@ class ApplicationHelper::Toolbar::CloudNetworksCenter < ApplicationHelper::Toolb
             t = N_('Edit selected Cloud Network'),
             t,
             :url_parms => 'main_div',
+            :send_checked => true,
             :enabled   => false,
             :onwhen    => '1'),
           button(
@@ -30,6 +31,7 @@ class ApplicationHelper::Toolbar::CloudNetworksCenter < ApplicationHelper::Toolb
             t = N_('Delete selected Cloud Networks'),
             t,
             :url_parms => 'main_div',
+            :send_checked => true,
             :confirm   => N_('Warning: The selected Cloud Networks and ALL of their components will be removed!'),
             :enabled   => false,
             :onwhen    => '1+')
diff --git a/app/helpers/application_helper/toolbar/flavors_center.rb b/app/helpers/application_helper/toolbar/flavors_center.rb
index add8b31ec9..052ea3b882 100644
--- a/app/helpers/application_helper/toolbar/flavors_center.rb
+++ b/app/helpers/application_helper/toolbar/flavors_center.rb
@@ -20,6 +20,7 @@ class ApplicationHelper::Toolbar::FlavorsCenter < ApplicationHelper::Toolbar::Ba
           t = N_('Remove selected Flavors'),
           t,
           :url_parms => "main_div",
+          :send_checked => true,
           :confirm   => N_("Warning: The selected Flavors will be permanently removed!"),
           :enabled   => false,
           :onwhen    => "1+"

@lpichler
Copy link
Contributor Author

lpichler commented Jan 4, 2018

@himdel definitely :)

@lpichler lpichler force-pushed the fix_missing_send_check_for_NetworkRouters_toolbar branch from ce75589 to 12dbc74 Compare January 5, 2018 13:53
@lpichler
Copy link
Contributor Author

lpichler commented Jan 5, 2018

Done 👍

@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2018

Checked commit lpichler@12dbc74 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@himdel himdel closed this Jan 8, 2018
@himdel himdel reopened this Jan 8, 2018
@himdel himdel merged commit e9ad491 into ManageIQ:master Jan 8, 2018
@himdel himdel added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 8, 2018
@lpichler lpichler deleted the fix_missing_send_check_for_NetworkRouters_toolbar branch January 8, 2018 17:00
@simaishi
Copy link
Contributor

simaishi commented Jan 8, 2018

#2398 isn't backported to Gaprindashvili, so I assume this shouldn't be gaprindashvili/yes ?

@simaishi
Copy link
Contributor

@lpichler @himdel ^ ping

@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

@lpichler @himdel ping ^

@lpichler
Copy link
Contributor Author

lpichler commented Mar 7, 2018

@simaishi we don't have related feature (edit cloud provider) in gaprindashvili so I think that this shouldn't go to gaprindashvili. @himdel please confirm.

@himdel
Copy link
Contributor

himdel commented Mar 8, 2018

Confirmed, #2398 never made it in gaprindashvili .. changing to no, sorry :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants