Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected format for buttons attribute in Service Dialogs #3163

Merged
merged 1 commit into from Jan 8, 2018

Conversation

romanblanco
Copy link
Member

Corrected format for buttons attribute for Service Dialogs

response to comment #2986 (comment)

@romanblanco
Copy link
Member Author

@miq-bot assign @himdel

@miq-bot
Copy link
Member

miq-bot commented Jan 4, 2018

Checked commit romanblanco@1d37edc with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@himdel
Copy link
Contributor

himdel commented Jan 4, 2018

spec/controllers/miq_ae_customization_controller/dialogs_spec.rb
212:          :dialog_buttons => ['submit, cancel']
365:          :dialog_buttons => ['submit, cancel']
427:          :dialog_buttons => ['submit, cancel']

(but that doesn't seem to matter) .. waiting for travis to make sure :)

@martinpovolny
Copy link

@romanblanco : please, label this PR

@romanblanco
Copy link
Member Author

@miq-bot add_label bug
@miq-bot add_label gaprindashvili/yes
@miq-bot add_label automation/automate

@himdel himdel merged commit 86c840a into ManageIQ:master Jan 8, 2018
@himdel himdel added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 8, 2018
@romanblanco romanblanco deleted the dialog_buttons_split branch January 8, 2018 13:48
simaishi pushed a commit that referenced this pull request Jan 8, 2018
Corrected format for buttons attribute in Service Dialogs
(cherry picked from commit 86c840a)
@simaishi
Copy link
Contributor

simaishi commented Jan 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 03e282ff3aeae7aaafe47400041f0879269463b8
Author: Martin Hradil <himdel@seznam.cz>
Date:   Mon Jan 8 14:43:51 2018 +0100

    Merge pull request #3163 from romanblanco/dialog_buttons_split
    
    Corrected format for buttons attribute in Service Dialogs
    (cherry picked from commit 86c840a903df599d33b574f5d6a8341610b67009)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants