Scan Storage via EMS not Host #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the requirement for hosts with valid credentials to be able to run storage smartstate. The valid unsupported reasons will be moved to the Storage model. https://bugzilla.redhat.com/show_bug.cgi?id=1529725
|
Checked commit agrare@5dcd9e3 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
I'm guessing spec failures will clean up once the backend PRs are merged? |
|
Exactly I moved the supported checks to the storage model (where they should be IMO) so once that's in this will pass. |
|
Backend PRs merged. Bounced this PR. |
|
Hm the javascript tests timed out, kicking the tests again |
|
Looks like the same issue on master https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/329142187#L2755-L2758 |
|
@Fryguy travis is green |
simaishi
pushed a commit
that referenced
this pull request
Jan 16, 2018
…a_ems Scan Storage via EMS not Host (cherry picked from commit 805fae2) https://bugzilla.redhat.com/show_bug.cgi?id=1534753
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the requirement for hosts with valid credentials to be able to
run storage smartstate. The valid unsupported reasons will be moved to
the Storage model.
Depends ManageIQ/manageiq#16743
https://bugzilla.redhat.com/show_bug.cgi?id=1529725