Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failing middleware tests #3178

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

mzazrivec
Copy link
Contributor

No description provided.

@himdel
Copy link
Contributor

himdel commented Jan 5, 2018

Fixes https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/324614558#L2746

  1) MiddlewareServerController#show render display textual groups
     Failure/Error: is_expected.to have_http_status 200
       expected the response to have status code 200 but it was 500
     # ./spec/controllers/middleware_server_controller_spec.rb:35:in `block (4 levels) in <top (required)>'
  2) MiddlewareServerController#show render display listnav partial
     Failure/Error: is_expected.to render_template(:partial => 'layouts/listnav/_middleware_server')
     
       expecting partial <layouts/listnav/_middleware_server> but action rendered <["layouts/_flash_msg", "_flash_msg", "shared/summary/_icon_or_image", "_icon_or_image", "shared/summary/_textual", "_textual", "shared/summary/_textual_tags", "_textual_tags", "layouts/_textual_groups_raw", "_textual_groups_raw", "layouts/_textual_groups_generic", "_textual_groups_generic", "layouts/_exception_contents", "_exception_contents", "layouts/_doctype", "_doctype", "stylesheets/_template50", "_template50", "layouts/_i18n_js", "_i18n_js", "layouts/_about_modal", "_about_modal", "layouts/_user_options", "_user_options", "layouts/_spinner", "_spinner", "layouts/_lightbox_panel", "_lightbox_panel", "layouts/_notifications_drawer", "_notifications_drawer", "layouts/_toast_list", "_toast_list", "layouts/_header", "_header", "layouts/_vertical_navbar", "_vertical_navbar", "layouts/_breadcrumbs", "_breadcrumbs", "layouts/_center_div_no_listnav", "_center_div_no_listnav", "layouts/_content", "_content", "layouts/_adv_search", "_adv_search", "layouts/_footer", "_footer"]>.
       Expected {"layouts/_flash_msg"=>1, "_flash_msg"=>1, "shared/summary/_icon_or_image"=>6, "_icon_or_image"=>6, "shared/summary/_textual"=>2, "_textual"=>2, "shared/summary/_textual_tags"=>1, "_textual_tags"=>1, "layouts/_textual_groups_raw"=>1, "_textual_groups_raw"=>1, "layouts/_textual_groups_generic"=>1, "_textual_groups_generic"=>1, "layouts/_exception_contents"=>1, "_exception_contents"=>1, "layouts/_doctype"=>1, "_doctype"=>1, "stylesheets/_template50"=>1, "_template50"=>1, "layouts/_i18n_js"=>1, "_i18n_js"=>1, "layouts/_about_modal"=>1, "_about_modal"=>1, "layouts/_user_options"=>1, "_user_options"=>1, "layouts/_spinner"=>1, "_spinner"=>1, "layouts/_lightbox_panel"=>1, "_lightbox_panel"=>1, "layouts/_notifications_drawer"=>1, "_notifications_drawer"=>1, "layouts/_toast_list"=>1, "_toast_list"=>1, "layouts/_header"=>1, "_header"=>1, "layouts/_vertical_navbar"=>1, "_vertical_navbar"=>1, "layouts/_breadcrumbs"=>1, "_breadcrumbs"=>1, "layouts/_center_div_no_listnav"=>1, "_center_div_no_listnav"=>1, "layouts/_content"=>1, "_content"=>1, "layouts/_adv_search"=>1, "_adv_search"=>1, "layouts/_footer"=>1, "_footer"=>1} to include "layouts/listnav/_middleware_server".
     # ./spec/controllers/middleware_server_controller_spec.rb:40:in `block (4 levels) in <top (required)>'
  3) MiddlewareServerController#show render display other specific partials
     Failure/Error: is_expected.to render_template(:partial => 'middleware_shared/_ops_params')
     
       expecting partial <middleware_shared/_ops_params> but action rendered <["layouts/_flash_msg", "_flash_msg", "shared/summary/_icon_or_image", "_icon_or_image", "shared/summary/_textual", "_textual", "shared/summary/_textual_tags", "_textual_tags", "layouts/_textual_groups_raw", "_textual_groups_raw", "layouts/_textual_groups_generic", "_textual_groups_generic", "layouts/_exception_contents", "_exception_contents", "layouts/_doctype", "_doctype", "stylesheets/_template50", "_template50", "layouts/_i18n_js", "_i18n_js", "layouts/_about_modal", "_about_modal", "layouts/_user_options", "_user_options", "layouts/_spinner", "_spinner", "layouts/_lightbox_panel", "_lightbox_panel", "layouts/_notifications_drawer", "_notifications_drawer", "layouts/_toast_list", "_toast_list", "layouts/_header", "_header", "layouts/_vertical_navbar", "_vertical_navbar", "layouts/_breadcrumbs", "_breadcrumbs", "layouts/_center_div_no_listnav", "_center_div_no_listnav", "layouts/_content", "_content", "layouts/_adv_search", "_adv_search", "layouts/_footer", "_footer"]>.
       Expected {"layouts/_flash_msg"=>1, "_flash_msg"=>1, "shared/summary/_icon_or_image"=>6, "_icon_or_image"=>6, "shared/summary/_textual"=>2, "_textual"=>2, "shared/summary/_textual_tags"=>1, "_textual_tags"=>1, "layouts/_textual_groups_raw"=>1, "_textual_groups_raw"=>1, "layouts/_textual_groups_generic"=>1, "_textual_groups_generic"=>1, "layouts/_exception_contents"=>1, "_exception_contents"=>1, "layouts/_doctype"=>1, "_doctype"=>1, "stylesheets/_template50"=>1, "_template50"=>1, "layouts/_i18n_js"=>1, "_i18n_js"=>1, "layouts/_about_modal"=>1, "_about_modal"=>1, "layouts/_user_options"=>1, "_user_options"=>1, "layouts/_spinner"=>1, "_spinner"=>1, "layouts/_lightbox_panel"=>1, "_lightbox_panel"=>1, "layouts/_notifications_drawer"=>1, "_notifications_drawer"=>1, "layouts/_toast_list"=>1, "_toast_list"=>1, "layouts/_header"=>1, "_header"=>1, "layouts/_vertical_navbar"=>1, "_vertical_navbar"=>1, "layouts/_breadcrumbs"=>1, "_breadcrumbs"=>1, "layouts/_center_div_no_listnav"=>1, "_center_div_no_listnav"=>1, "layouts/_content"=>1, "_content"=>1, "layouts/_adv_search"=>1, "_adv_search"=>1, "layouts/_footer"=>1, "_footer"=>1} to include "middleware_shared/_ops_params".
     # ./spec/controllers/middleware_server_controller_spec.rb:44:in `block (4 levels) in <top (required)>'

coming from ManageIQ/manageiq#16720

@himdel
Copy link
Contributor

himdel commented Jan 5, 2018

Added gaprindashvili/yes since the removal PR is gaprindashvili/backported already

@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2018

Checked commit mzazrivec@0fdd72e with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@himdel
Copy link
Contributor

himdel commented Jan 5, 2018

And green, merging :).

Cc @simaishi, this should take care of the new gaprindashvili failures :)

@himdel himdel merged commit 778277c into ManageIQ:master Jan 5, 2018
@himdel himdel added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 5, 2018
@himdel himdel self-assigned this Jan 5, 2018
simaishi pushed a commit that referenced this pull request Jan 5, 2018
Remove failing middleware tests
(cherry picked from commit 778277c)
@simaishi
Copy link
Contributor

simaishi commented Jan 5, 2018

Gaprindashvili backport details:

$ git log -1
commit 4e5150eb7a8eed20dedfc9631cc605ca204e50f9
Author: Martin Hradil <himdel@seznam.cz>
Date:   Fri Jan 5 18:26:59 2018 +0100

    Merge pull request #3178 from mzazrivec/remove_failing_middleware_tests
    
    Remove failing middleware tests
    (cherry picked from commit 778277cc481f9280c19506c0ea2ecad540edac3e)

@mzazrivec mzazrivec deleted the remove_failing_middleware_tests branch February 22, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants