Delete unnecessary X.empty? check after calling find_record_with_rbac

[PanSpagetka]

Delete unnecessary X.empty? check after calling find_record_with_rbac. After #3131 find_record_with_rbac raises exception if it should return empty array.

Links

#3131

[miq-bot]

Checked commit PanSpagetka@f468658 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

[romanblanco]

Looks good 👍

[romanblanco]

@miq-bot add_label technical debt
@miq-bot add_label gaprindashvili/no
@miq-bot assign @martinpovolny

[martinpovolny]

Are we sure that with the normal order of operations the no selection case is properly handled?

[romanblanco]

@martinpovolny I'm not sure what you mean by properly handled.

At current state, find_records_with_rbac raises an exception in case it receives an empty list of records (which user should not be able to send in normal situation, AFAIK), or in case user tries to fetch records he's not permited to access.

I can't think of any case where the user could run into an exception after doing steps he's expected to do. In all other cases I think the users workflow was incorrect, or there was other error in the code, and thus he should end up with an exception.

So I'd say it is. Or is there something more that should be kept in mind?

[PanSpagetka]

Agree with @romanblanco when it blows up user either was doing something, he shouldn't be doing or there is some bug in the code. Deleting X.empty? conditions doesn't change the behavior at all.