Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added RBAC filtering to HAC and VAT tree builder code. #3210

Merged
merged 1 commit into from Jan 9, 2018
Merged

Added RBAC filtering to HAC and VAT tree builder code. #3210

merged 1 commit into from Jan 9, 2018

Conversation

h-kataria
Copy link
Contributor

Only show nodes in the tree that user has access to.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1525000

before:
hac_tree_before

vat_tree_before

after:
hac_tree_after

vat_tree_after

@h-kataria
Copy link
Contributor Author

@dclarizio please review.

@dclarizio dclarizio added the rbac label Jan 9, 2018
@h-kataria
Copy link
Contributor Author

@AparnaKarve can you please test

@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2018

Checked commit h-kataria@9d71bee with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@AparnaKarve
Copy link
Contributor

Tested in UI - looks good!

@dclarizio dclarizio merged commit 5e755bc into ManageIQ:master Jan 9, 2018
@dclarizio dclarizio added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 9, 2018
simaishi pushed a commit that referenced this pull request Jan 10, 2018
@simaishi
Merge pull request #3210 from h-kataria/hac_vat_tree_access_fix
7836adf 
Added RBAC filtering to HAC and VAT tree builder code.
(cherry picked from commit 5e755bc)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533229
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 7836adffea5c95983f7873c3491da6147d607a84
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Tue Jan 9 14:42:01 2018 -0800

    Merge pull request #3210 from h-kataria/hac_vat_tree_access_fix
    
    Added RBAC filtering to HAC and VAT tree builder code.
    (cherry picked from commit 5e755bc176ab9346fe8ddf79274cea2eeb1dacd3)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533229

@h-kataria h-kataria deleted the hac_vat_tree_access_fix branch March 14, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AparnaKarve AparnaKarve AparnaKarve approved these changes

Assignees

@dclarizio dclarizio

Labels
bug gaprindashvili/backported rbac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@h-kataria @miq-bot @AparnaKarve @simaishi @dclarizio