Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiselect dropdown issue #3237

Merged
merged 1 commit into from Jan 13, 2018
Merged

Fix multiselect dropdown issue #3237

merged 1 commit into from Jan 13, 2018

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Jan 12, 2018 •
edited

After #3192 merge, we no longer need the data-container setting for the dropdowns.

This fixes -

  • The multiselect dropdown linger issue described in the BZ
  • Also, does not cut-off dropdowns on Provisioning screens

Related PR - #3176

https://bugzilla.redhat.com/show_bug.cgi?id=1533808

@AparnaKarve
Copy link
Contributor Author

@epwinchell Please review.

@dclarizio dclarizio self-assigned this Jan 12, 2018
@dclarizio dclarizio assigned h-kataria and unassigned dclarizio Jan 12, 2018
@h-kataria h-kataria added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 13, 2018
@h-kataria h-kataria merged commit 95d7166 into ManageIQ:master Jan 13, 2018
simaishi pushed a commit that referenced this pull request Jan 15, 2018
@h-kataria @simaishi
Merge pull request #3237 from AparnaKarve/bz1533808_no_datacontainer_…
b0573d3 
…necessary

Fix multiselect dropdown issue
(cherry picked from commit 95d7166)

https://bugzilla.redhat.com/show_bug.cgi?id=1534578
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit b0573d3e379e3e47caf177acfa9d2deb949d416d
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Sat Jan 13 16:27:46 2018 -0500

    Merge pull request #3237 from AparnaKarve/bz1533808_no_datacontainer_necessary
    
    Fix multiselect dropdown issue
    (cherry picked from commit 95d7166c4def6975259ca1ebef3384454587aa74)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1534578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epwinchell epwinchell epwinchell approved these changes

Assignees

@h-kataria h-kataria

Labels
blocker bug gaprindashvili/backported old dialogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AparnaKarve @simaishi @epwinchell @dclarizio @h-kataria