Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display toolbars in the CustomButton/Custom Group form #3258

Merged
merged 2 commits into from Jan 17, 2018
Merged

Do not display toolbars in the CustomButton/Custom Group form #3258

merged 2 commits into from Jan 17, 2018

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Jan 16, 2018 •
edited

Set the visibility of toolbars to false while rendering forms.

Before (Toolbar visible in the form)
screen shot 2018-01-16 at 2 23 14 pm

After (Toolbar not displayed in the form)
screen shot 2018-01-16 at 2 18 27 pm

https://bugzilla.redhat.com/show_bug.cgi?id=1534534

@AparnaKarve
Copy link
Contributor Author

@miq-bot add_label bug,blocker,gaprindashvili/yes,generic objects

@AparnaKarve
Copy link
Contributor Author

/cc @h-kataria

@miq-bot
Copy link
Member

miq-bot commented Jan 16, 2018

Checked commits AparnaKarve/manageiq-ui-classic@bfbc5d1~...aea1c7c with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@AparnaKarve AparnaKarve reopened this Jan 16, 2018
@h-kataria h-kataria self-assigned this Jan 16, 2018
@h-kataria h-kataria added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 17, 2018
@h-kataria
Copy link
Contributor

looks good

@h-kataria h-kataria merged commit 291519f into ManageIQ:master Jan 17, 2018
@AparnaKarve AparnaKarve deleted the bz1534534_fix_tb_buttons branch January 17, 2018 15:12
simaishi pushed a commit that referenced this pull request Jan 17, 2018
@h-kataria @simaishi
Merge pull request #3258 from AparnaKarve/bz1534534_fix_tb_buttons
896b275 
Do not display toolbars in the CustomButton/Custom Group form
(cherry picked from commit 291519f)

https://bugzilla.redhat.com/show_bug.cgi?id=1535609
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 896b2751349f9fa977d2cc385542d262f15e40ba
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Jan 17 09:33:08 2018 -0500

    Merge pull request #3258 from AparnaKarve/bz1534534_fix_tb_buttons
    
    Do not display toolbars in the CustomButton/Custom Group form
    (cherry picked from commit 291519fcc6c60f9fc498ba5a58d573db74590cd7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1535609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
blocker bug gaprindashvili/backported generic objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AparnaKarve @miq-bot @h-kataria @simaishi