Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing Tags for Cloud Subnets #3287

Merged

Conversation

hstastna
Copy link
Contributor

@hstastna hstastna commented Jan 19, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534915

Fix editing Tags for Cloud Subnets when going to Networks -> Networks, choosing a network, selecting Cloud Subnets in Relationships table and selecting some subnets by checking the checkboxes in the list and clicking on Edit Tags under Policy.
cloud_subnet_edit_tags

Before:
cloud_subnet_before

After:
cloud_subnet_tag

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534915

Fix editing Tags for Cloud Subnets when going to Networks -> Networks,
choosing a network, selecting Cloud Subnets and selecting some Subnets
by checking the checkboxes in the list and clicking on Edit Tags under
Policy.
@hstastna
Copy link
Contributor Author

@miq-bot add_label bug, gaprindashvili/yes, fine/yes, blocker

@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2018

Checked commit hstastna@4151159 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec self-assigned this Jan 22, 2018
@mzazrivec mzazrivec added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 22, 2018
@mzazrivec mzazrivec merged commit b1ce307 into ManageIQ:master Jan 22, 2018
simaishi pushed a commit that referenced this pull request Jan 22, 2018
…x_Networks

Fix editing Tags for Cloud Subnets
(cherry picked from commit b1ce307)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537144
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 540068abad8f7d611453a3dfa5785f99ee4b9002
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Jan 22 07:02:14 2018 +0100

    Merge pull request #3287 from hstastna/Edit_Tag_Cloud_Subnets_checkbox_Networks
    
    Fix editing Tags for Cloud Subnets
    (cherry picked from commit b1ce307ecfb9e0c4e5959923f2164a56df511f2f)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537144

simaishi pushed a commit that referenced this pull request Jan 22, 2018
…x_Networks

Fix editing Tags for Cloud Subnets
(cherry picked from commit b1ce307)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537145
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 20e2b478d0f484fbe659619c3ca49feda9861d4c
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Jan 22 07:02:14 2018 +0100

    Merge pull request #3287 from hstastna/Edit_Tag_Cloud_Subnets_checkbox_Networks
    
    Fix editing Tags for Cloud Subnets
    (cherry picked from commit b1ce307ecfb9e0c4e5959923f2164a56df511f2f)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants