Fix for dialog loading issue and wrong redirect #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits eclarizio/manageiq-ui-classic@dfba8fd~...7c4bbd3 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
looks good |
simaishi
pushed a commit
that referenced
this pull request
Jan 23, 2018
Fix for dialog loading issue and wrong redirect (cherry picked from commit 5408a4b) https://bugzilla.redhat.com/show_bug.cgi?id=1537567
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a small oversight where regardless of where the Vm instance was being shown (either on vm_infra or vm_cloud), when clicking on a custom button and then either cancelling or submitting we would be redirecting back to /vm_infra/explorer instead of the appropriate location.
This PR also adds a spinner to the dialog runner while it is loading.
https://bugzilla.redhat.com/show_bug.cgi?id=1536204
@miq-bot add_label gaprindashvili/yes, bug, blocker
@miq-bot assign @h-kataria