[FINE] Fix show top VM/Host in C&U chart grouped by some tag #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label blocker |
|
LGTM, Comes from #652, This is much less intrusive than backporting the whole PR now 👍 But the exact same problem is also present in |
PanSpagetka
force-pushed
the
fine-fix-cu-topvm-by-tag
branch
from
6907a06
to
07db446
Compare
|
Checked commits PanSpagetka/manageiq-ui-classic@0d37abe~...07db446 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix show top VM/Host in C&U chart grouped by some tag. In
chart_top_by_tagwas used variabletypbut it wasn't defined.Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1531619
https://bugzilla.redhat.com/show_bug.cgi?id=1531615
Steps for Testing/QA