Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing i18n in notification drawer #3319

Merged
merged 1 commit into from Jan 30, 2018
Merged

Fix missing i18n in notification drawer #3319

merged 1 commit into from Jan 30, 2018

Conversation

mzazrivec
Copy link
Contributor

The text 0 New 1 New 2 New etc. in notification drawer wasn't being translated.

https://bugzilla.redhat.com/show_bug.cgi?id=1538087

@miq-bot
Copy link
Member

miq-bot commented Jan 25, 2018

Checked commit mzazrivec@2443bdd with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@martinpovolny martinpovolny self-assigned this Jan 30, 2018
@martinpovolny martinpovolny merged commit 50d1a9a into ManageIQ:master Jan 30, 2018
@martinpovolny martinpovolny added this to the Sprint 79 Ending Feb 12, 2018 milestone Jan 30, 2018
@mzazrivec mzazrivec deleted the missing_i18n_in_notif_drawer branch January 30, 2018 14:22
simaishi pushed a commit that referenced this pull request Mar 7, 2018
@simaishi
Merge pull request #3319 from mzazrivec/missing_i18n_in_notif_drawer
531f717 
Fix missing i18n in notification drawer
(cherry picked from commit 50d1a9a)

https://bugzilla.redhat.com/show_bug.cgi?id=1552751
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 531f7176bc27b1b4ac44c9fa1795d9d66f747bd7
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Tue Jan 30 15:21:10 2018 +0100

    Merge pull request #3319 from mzazrivec/missing_i18n_in_notif_drawer
    
    Fix missing i18n in notification drawer
    (cherry picked from commit 50d1a9ac137a05bcbe8584248a09a945b5e78184)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug gaprindashvili/backported internationalization notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzazrivec @miq-bot @simaishi @martinpovolny