Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ansible Repo Add and Edit confirmation messages #3327

Merged
merged 1 commit into from Jan 29, 2018

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Jan 26, 2018

Fixes confirmation messages when Adding or Editing Ansible Repository.

https://bugzilla.redhat.com/show_bug.cgi?id=1500917

Screen shot prior to code fix:
ansible repo add initialized message

Screen shots post code fix:
ansible repo add initiated message post code fix

ansible repo edit initiated message post code fix

@miq-bot
Copy link
Member

miq-bot commented Jan 26, 2018

Checked commit GregP@ba5c625 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@h-kataria h-kataria self-assigned this Jan 29, 2018
@h-kataria h-kataria added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 29, 2018
@h-kataria h-kataria merged commit efb9214 into ManageIQ:master Jan 29, 2018
simaishi pushed a commit that referenced this pull request Mar 7, 2018
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit caee2acc4e934acbd831fe24861a3c1d6dd3858e
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Jan 29 13:28:20 2018 -0500

    Merge pull request #3327 from GregP/fix_add_edit_ansible_repo_messages
    
    Fix Ansible Repo Add and Edit confirmation messages
    (cherry picked from commit efb9214447891600786ba4e2a2449074306d98df)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants