Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove container statuses table from pod summary page #3332

Merged
merged 1 commit into from Jan 30, 2018

Conversation

zeari
Copy link

@zeari zeari commented Jan 29, 2018

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1539370
This table usually doesnt help the user. In most cases its a constant 1/1 running containers type of information.

Before:
manageiq pods

After:
screencapture-localhost-3000-container_group-show-16-1517219694413

@nimrodshn @yaacov Please review
cc @oourfali

@miq-bot add_label compute/containers

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miq-bot
Copy link
Member

miq-bot commented Jan 29, 2018

Checked commit zeari@f6a48f9 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Jan 30, 2018
@mzazrivec mzazrivec added this to the Sprint 79 Ending Feb 12, 2018 milestone Jan 30, 2018
@mzazrivec mzazrivec merged commit 71eddae into ManageIQ:master Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants