Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged Container Providers with all other providers in the list #3368

Merged
merged 1 commit into from Feb 5, 2018
Merged

Merged Container Providers with all other providers in the list #3368

merged 1 commit into from Feb 5, 2018

Conversation

h-kataria
Copy link
Contributor

Need to merge and keep all kind of providers under same entry to be able ot save chargeback assignments for different types of providers together.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505335

before:
before
before1

after:
after

@h-kataria
Merged Container Providers with all other providers in the list
c3ea720 
Need to merge and keep all kind of providers under same entry to be able ot save chargeback assignments for different types of providers together.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505335
@miq-bot
Copy link
Member

miq-bot commented Feb 2, 2018

Checked commit h-kataria@c3ea720 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 5, 2018
@mzazrivec mzazrivec assigned mzazrivec and unassigned dclarizio Feb 5, 2018
@mzazrivec mzazrivec merged commit 6394620 into ManageIQ:master Feb 5, 2018
simaishi pushed a commit that referenced this pull request Feb 5, 2018
@mzazrivec @simaishi
Merge pull request #3368 from h-kataria/chargeback_assignment_provide…
f9b41b3 
…rs_list_merged

Merged Container Providers with all other providers in the list
(cherry picked from commit 6394620)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1542169
@simaishi
Copy link
Contributor

simaishi commented Feb 5, 2018

Gaprindashvili backport details:

$ git log -1
commit f9b41b3b414c906d5891e883c32326fc5deaa7d4
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Feb 5 09:15:52 2018 +0100

    Merge pull request #3368 from h-kataria/chargeback_assignment_providers_list_merged
    
    Merged Container Providers with all other providers in the list
    (cherry picked from commit 63946202771a168eb65a9bf3a84e616b304a23e5)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1542169

simaishi pushed a commit that referenced this pull request Feb 5, 2018
@mzazrivec @simaishi
Merge pull request #3368 from h-kataria/chargeback_assignment_provide…
b08f876 
…rs_list_merged

Merged Container Providers with all other providers in the list
(cherry picked from commit 6394620)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1542170
@simaishi
Copy link
Contributor

simaishi commented Feb 5, 2018

Fine backport details:

$ git log -1
commit b08f876b321918b3fdc1c330c216f933195d688d
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Feb 5 09:15:52 2018 +0100

    Merge pull request #3368 from h-kataria/chargeback_assignment_providers_list_merged
    
    Merged Container Providers with all other providers in the list
    (cherry picked from commit 63946202771a168eb65a9bf3a84e616b304a23e5)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1542170

@h-kataria h-kataria deleted the chargeback_assignment_providers_list_merged branch March 14, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

Assignees

@mzazrivec mzazrivec

Labels
blocker bug fine/backported gaprindashvili/backported overview/chargeback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@h-kataria @miq-bot @simaishi @dclarizio @mzazrivec