Fix tag CU chart when there are no daily data #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanSpagetka
changed the title
PanSpagetka
force-pushed
the
fix-cu-chart-no-data-tag
branch
2 times, most recently
from
2d58a7c
to
21d7bf6
Compare
|
This does prevent the crash when there are no records with capture_interval_name = 'daily' but there are records with 'capture_interval_name = 'hourly' for multiple days. |
PanSpagetka
force-pushed
the
fix-cu-chart-no-data-tag
branch
from
21d7bf6
to
5254e96
Compare
PanSpagetka
force-pushed
the
fix-cu-chart-no-data-tag
branch
from
5254e96
to
570c904
Compare
|
Checked commit PanSpagetka@570c904 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lgalis Are you OK with the proposed fix? Thanks. |
|
This PR fixes the crash, so I am OK with it. We can look at addressing the no-data situation better in a different PR upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tag CU chart when there are not enough daily data.
I think, that source of this problem is hidden in generating reports, but because i think it is related to blocker bz, I just fix consequences and return to it later.
Links [Optional]
Related(ish) with https://bugzilla.redhat.com/show_bug.cgi?id=1540129
Steps for Testing/QA [Optional]
Select host with some C&U data, but not for all day.
Utilization -> Group By (tag) -> Daily
Screenshots
Before:
After:
