Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing storage type images #3443

Merged
merged 1 commit into from Feb 22, 2018
Merged

Add missing storage type images #3443

merged 1 commit into from Feb 22, 2018

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Feb 21, 2018 •
edited

@epwinchell
Copy link
Contributor Author

@miq-bot add_label graphics, bug

@miq-bot
Copy link
Member

miq-bot commented Feb 21, 2018

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/ecf21badd19ec7d8234f4b4a15d14fa42f691e2d with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec self-assigned this Feb 22, 2018
@mzazrivec mzazrivec added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 22, 2018
@mzazrivec mzazrivec merged commit 2080e3f into ManageIQ:master Feb 22, 2018
@himdel himdel mentioned this pull request Feb 22, 2018
Closed
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

@epwinchell Please add BZ link.

@epwinchell
Copy link
Contributor Author

@miq-bot rm_label bugzilla needed

simaishi pushed a commit that referenced this pull request Mar 9, 2018
@mzazrivec @simaishi
Merge pull request #3443 from epwinchell/storagetype_images
f031dec 
Add missing storage type images
(cherry picked from commit 2080e3f)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553873
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2018

Gaprindashvili backport details:

$ git log -1
commit f031dec1a0600b483366f6ecdf5ba9acdea3bace
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Feb 22 10:59:16 2018 +0100

    Merge pull request #3443 from epwinchell/storagetype_images
    
    Add missing storage type images
    (cherry picked from commit 2080e3fd34c1d9ceb2c403af7849bdded34c245f)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553873

@epwinchell epwinchell deleted the storagetype_images branch March 20, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug gaprindashvili/backported graphics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@epwinchell @miq-bot @simaishi @mzazrivec