Fix closing dialog window when applying filter in Workloads #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ManageIQ#499 Fix closing dialog window when applying a filter if user inputs the value and clicks on Apply button, in Services > Workloads and other explorer screens.
|
Checked commit hstastna@1b60e5f with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 **
|
pkomanek
pushed a commit
to pkomanek/manageiq-ui-classic
that referenced
this pull request
Aug 20, 2019
Since ManageIQ#3444 (which fixed the user input filter modal to hide after Apply): * clicking the apply button triggers a ?button=apply request * but, thanks to data-dismiss="modal", it also closes the modal * BUT, closing the modal this way triggers a ?button=cancel request Thus, clicking apply triggers apply & cancel, in random order. Ideally, we should not be using data-dismiss on the Apply button, but using `$('#quicksearchbox').modal('hide')` in `quick_search_apply_click`, same as in `quick_search_cancel_click`. The problem with that is that this would involve changing every single `replace_right_cell`, or somehow amending their output after the fact. So, leaving the data-dismiss mechanism as is, but: * explicitly adding code to not send the ?button=cancel request when the Apply button was clicked * explicitly triggering hiding the modal when enter was clicked in the form (previously it would just apply) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1715550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #499
Fix closing dialog window when applying a filter after user inputs the value and clicks on Apply button, in Services > Workloads and other explorer screens, where this issue also occurs.
Right before applying a filter if user inputs the value:
Before: (filter is applied but dialog window did not close, after clicking on Apply button)
After: (dialog window has closed and everything looks good)
