Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed labels for Openstack Provider #3505

Merged
merged 1 commit into from Mar 2, 2018

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Mar 1, 2018

Fixed labels on all "Clusters" and "Hosts" related cards for Openstack providers to "Deployment Roles" and "Nodes"

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1430241

@dclarizio please review.

before:

Openstack Provider Dashboard
before_openstack_provider

Non-Openstack Provider Dashboard
before_non_openstack_provider

after:

Openstack Provider Dashboard
after_openstack_provider

Non-Openstack Provider Dashboard
after_non_opensatck_provider

Fixed labels on all "Clusters" and "Hosts" related cards for Openstack providers to "Deployment Roles" and "Nodes"

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1430241
@miq-bot
Copy link
Member

miq-bot commented Mar 1, 2018

Checked commit h-kataria@c8bcff5 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@dclarizio dclarizio added the bug label Mar 1, 2018
@mzazrivec mzazrivec assigned mzazrivec and unassigned dclarizio Mar 2, 2018
@mzazrivec mzazrivec added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 2, 2018
@mzazrivec mzazrivec merged commit ccc2304 into ManageIQ:master Mar 2, 2018
simaishi pushed a commit that referenced this pull request Mar 8, 2018
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 807318d81c4bef88a881ab28d2ec11ecfce7b61a
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Mar 2 14:19:06 2018 +0100

    Merge pull request #3505 from h-kataria/fixed_openstack_labels
    
    Fixed labels for Openstack Provider
    (cherry picked from commit ccc230420d40cd1734b6cea7bef443b5bc2ee25a)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553345

@h-kataria h-kataria deleted the fixed_openstack_labels branch March 14, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants