Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack - clean up loaders, support es6 in node_modules #3506

Merged
merged 5 commits into from
Mar 7, 2018
Merged

Webpack - clean up loaders, support es6 in node_modules #3506

merged 5 commits into from
Mar 7, 2018

Commits on Mar 1, 2018

  1. Webpack - remove coffeescript & erb loaders 

    we have no coffescript or erb code, not in ui-classic, not in ui-componets or in v2v plugin
no point in having the loaders
    @himdel
    himdel committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    eb4bfaa View commit details
    Browse the repository at this point in the history

  2. Webpack loaders - consistently use \.(extensions)$ regex, drop option… 

    …al erb

we don't support erb, and the typescript loader was matching anything ending in ts, not .ts
    @himdel
    himdel committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    73730aa View commit details
    Browse the repository at this point in the history

  3. Webpack loaders - don't ignore node_modules 

    we still want to compile es6 code to es5, regardless whether this comes from our code or from a npm dependency
    @himdel
    himdel committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    827c781 View commit details
    Browse the repository at this point in the history

  4. Drop unused loaders from package.json 

    no coffescript or erb anywhere in manageiq
    @himdel
    himdel committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    4d12601 View commit details
    Browse the repository at this point in the history

  5. webpack - Drop coffee & erb from supported extensions, add tsx

    @himdel
    himdel committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    1688677 View commit details
    Browse the repository at this point in the history