Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve Jest, TypeScript and webpack(er) configs #3517

Closed

Conversation

vojtechszocs
Copy link
Contributor

Jest config

TypeScript config

  • use "jsx": "react" in compiler options so that JSX gets compiled to JS code containing React.createElement calls

webpack(er) config

  • add .tsx to file extensions in webpacker.yml
  • the vendor chunk is no longer empty - it now contains webpack runtime and all code that comes from 3rd party modules (anything that comes from node_modules)

It's important to load vendor before any *-common chunks, as it contains webpack runtime (e.g. the webpackJsonp global) as well as common 3rd party modules.

@vojtechszocs
Copy link
Contributor Author

cc @karelhala @himdel

@miq-bot
Copy link
Member

miq-bot commented Mar 7, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2018

Checked commit vojtechszocs@a136d06 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@miq-bot
Copy link
Member

miq-bot commented Mar 9, 2018

This pull request is not mergeable. Please rebase and repush.

presets: ['react'],
},
};
presets: ['react']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't :)

@@ -132,5 +132,7 @@ boot_files:
# show_console_log
#
# Tell PhantomJS runner to enable console.log output from your specs.

#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't :)

@himdel
Copy link
Contributor

himdel commented Mar 12, 2018

Extracted the "clearly good" bits to #3576 and #3575. (And #3577.)

If you can remove those and remove the non-changes (adding an example comment, removing commas from config), this will nicely simplify to a jest-only PR :).

(I have no real objections to the jest-related changes, it's just this was doing too many unrelated things, and unmergeable, so I split off the stuff we need in first :).)

@vojtechszocs
Copy link
Contributor Author

Extracted the "clearly good" bits to #3576 and #3575. (And #3577.)

If you can remove those and remove the non-changes (adding an example comment, removing commas from config), this will nicely simplify to a jest-only PR :).

(I have no real objections to the jest-related changes, it's just this was doing too many unrelated things, and unmergeable, so I split off the stuff we need in first :).)

Thanks @himdel - I agree, I'll take out the stuff that was extracted and update this PR.

@martinpovolny martinpovolny changed the title Improve Jest, TypeScript and webpack(er) configs [WIP] Improve Jest, TypeScript and webpack(er) configs Apr 10, 2018
@miq-bot
Copy link
Member

miq-bot commented Oct 12, 2018

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!

@miq-bot miq-bot closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants