New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improve Jest, TypeScript and webpack(er) configs #3517
Conversation
82256a9
to
29c75da
Compare
This pull request is not mergeable. Please rebase and repush. |
29c75da
to
a136d06
Compare
Checked commit vojtechszocs@a136d06 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This pull request is not mergeable. Please rebase and repush. |
presets: ['react'], | ||
}, | ||
}; | ||
presets: ['react'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't :)
@@ -132,5 +132,7 @@ boot_files: | |||
# show_console_log | |||
# | |||
# Tell PhantomJS runner to enable console.log output from your specs. | |||
|
|||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't :)
Extracted the "clearly good" bits to #3576 and #3575. (And #3577.) If you can remove those and remove the non-changes (adding an example comment, removing commas from config), this will nicely simplify to a jest-only PR :). (I have no real objections to the jest-related changes, it's just this was doing too many unrelated things, and unmergeable, so I split off the stuff we need in first :).) |
Thanks @himdel - I agree, I'll take out the stuff that was extracted and update this PR. |
This pull request has been automatically closed because it has not been updated for at least 6 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! |
Jest config
setupFiles
vssetupTestFrameworkScriptFile
in order to load enhancers like angular-mocksmoduleFileExtensions
to cover .js(x) and .ts(x) filesManageIQ.angular.app
for testing purposesspyOnDeeply
test helper, this will be needed in a follow-up PRTypeScript config
"jsx": "react"
in compiler options so that JSX gets compiled to JS code containingReact.createElement
callswebpack(er) config
webpacker.yml
vendor
chunk is no longer empty - it now contains webpack runtime and all code that comes from 3rd party modules (anything that comes fromnode_modules
)It's important to load
vendor
before any*-common
chunks, as it contains webpack runtime (e.g. thewebpackJsonp
global) as well as common 3rd party modules.