Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show policy status when running policy simulation #3524

Merged
merged 1 commit into from Mar 12, 2018

Conversation

karelhala
Copy link
Contributor

Policy simulation status

When in policy simulation and user changes Policy Profile no status is visible because quadicon is not used in this list.

This PR fixes such issue so when selecting Policy Profiles user sees status of policy simulation. If no policy simulation is visible show number of total snapshots

UI changes

Before

screenshot from 2018-03-01 10-56-04 1

After

No policy profile selected
screenshot from 2018-03-07 13-27-17
Policiy profile selected, but different policy assigned
screenshot from 2018-03-07 13-27-24

BZ

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1550503

@karelhala
Copy link
Contributor Author

@miq-bot assign @martinpovolny
@miq-bot add_label bug, gaprindashvili/yes, blocker
@skateman this is fix for your BZ you opened

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@skateman
Copy link
Member

skateman commented Mar 8, 2018

@karelhala you missed the MiqTemplateDecorator, it also has policies and it's not updated 😢

@karelhala
Copy link
Contributor Author

@karelhala you missed the MiqTemplateDecorator, it also has policies and it's not updated 😢

Done

@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2018

Checked commit karelhala@fded52e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@karelhala karelhala closed this Mar 12, 2018
@karelhala karelhala reopened this Mar 12, 2018
@martinpovolny martinpovolny merged commit c9ff8fa into ManageIQ:master Mar 12, 2018
@martinpovolny martinpovolny added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 12, 2018
@skateman
Copy link
Member

@karelhala @simaishi this will definitely have merge conflicts

@simaishi
Copy link
Contributor

Backported to Gaprindashvili via #3606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants