Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description on VMRC configuration tab #3529

Merged

Conversation

bmclaughlin
Copy link
Contributor

Update no longer accurate description in the VMRC Console tab.

https://bugzilla.redhat.com/show_bug.cgi?id=1552147

@bmclaughlin
Copy link
Contributor Author

@miq-bot add_labels bug, compute/infrastructure

Before:
1552147-before

After:
1552147-after

@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2018

This pull request is not mergeable. Please rebase and repush.

@bmclaughlin bmclaughlin force-pushed the update-vmrc-config-tab-description branch from 48798a4 to 91796bb Compare March 12, 2018 13:27
@bmclaughlin bmclaughlin force-pushed the update-vmrc-config-tab-description branch from 91796bb to 7e1e8c8 Compare March 12, 2018 13:29
@miq-bot
Copy link
Member

miq-bot commented Mar 12, 2018

Checked commit bmclaughlin@7e1e8c8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec mzazrivec self-assigned this Mar 13, 2018
@mzazrivec mzazrivec added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 13, 2018
@mzazrivec mzazrivec merged commit 453a9a5 into ManageIQ:master Mar 13, 2018
@bmclaughlin bmclaughlin deleted the update-vmrc-config-tab-description branch March 13, 2018 12:27
@simaishi
Copy link
Contributor

The text was changed to "If not set, the VMRC console access will be disabled for this provider" in 0b11ca4, for https://bugzilla.redhat.com/show_bug.cgi?id=1550612. Are we sure we want to remove that text?

cc @skateman

@skateman
Copy link
Member

Ugh, why this got merged? @mzazrivec

@skateman
Copy link
Member

@simaishi @bmclaughlin the BZ above is referring to something old that has been already updated, this PR should be reverted and the BZ closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants