Apply RBAC filtering to cloud networks when creating floating ips #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
approved these changes
Mar 7, 2018
|
@miq-bot add_label gaprindashvili/yes Fine bug: https://bugzilla.redhat.com/show_bug.cgi?id=1552780 |
|
looks good, restarted failing tests, ready to merge after tests are green. |
|
Looks good to me 👍 |
|
@mansam can you rebase/repush your branch, lets see if that fixes unrelated travis test failures. |
mansam
force-pushed
the
filter-networks-for-floating-ips
branch
from
96b5e2f
to
7ddf1eb
Compare
|
Checked commit mansam@7ddf1eb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@h-kataria and I agree the failing tests are unrelated to this change . . . merging |
simaishi
pushed a commit
that referenced
this pull request
Mar 9, 2018
Apply RBAC filtering to cloud networks when creating floating ips (cherry picked from commit 4773d1f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553787
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 10, 2018
Apply RBAC filtering to cloud networks when creating floating ips (cherry picked from commit 4773d1f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552780
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1549763