Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset_data_uri - fix bower_components paths #3543

Merged
merged 2 commits into from Mar 9, 2018
Merged

asset_data_uri - fix bower_components paths #3543

merged 2 commits into from Mar 9, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Mar 8, 2018

this was overlooked in #3343

bower deps using asset_data_uri also need the bower_components/ prefix now

Fixes #3542

Cc @hstastna can you test please?
Cc @skateman

this was overlooked in #3343

bower deps using `asset_data_uri` also need the `bower_components/` prefix now
@hstastna
Copy link
Contributor

hstastna commented Mar 8, 2018

@himdel It does not work for me. But maybe I need also to run some commands.. I am not sure. Any ideas?

@himdel
Copy link
Contributor Author

himdel commented Mar 8, 2018

@hstastna What's the new error? There should be no extra commands needed (except for bower install :)).

Also, does manageiq-ui-classic/vendor/assets/bower/bower_components/patternfly/dist/fonts/PatternFlyIcons-webfont.ttf exist on your machine?

@hstastna
Copy link
Contributor

hstastna commented Mar 8, 2018

@himdel Yes, I've run bower install and yes, manageiq-ui-classic/vendor/assets/bower/bower_components/patternfly/dist/fonts/PatternFlyIcons-webfont.ttf exists on my machine. And the error looks very similar:
bower_components_err
Am I doing something wrong? Does it work for you?

@himdel
Copy link
Contributor Author

himdel commented Mar 8, 2018

Aaah.. so it now fails on an entirely different file :).

Thanks, that font-awesome path is missing a /fonts in the path.. added, can you re-test please? :)

@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2018

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/1a9f4d65117698b4f9a65541d8c9bbe2fe4ba40b~...fad64b595d2ea7849cbb74487744bcd24c7dfabe with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@hstastna
Copy link
Contributor

hstastna commented Mar 9, 2018

@himdel Ahh, yes, now I see too, what was missing. Yes, it works now! 🥇 Thank you!

@mzazrivec mzazrivec self-assigned this Mar 9, 2018
@mzazrivec mzazrivec added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 9, 2018
@mzazrivec mzazrivec merged commit bc9938a into ManageIQ:master Mar 9, 2018
@himdel himdel deleted the fix-asset-data-uri-paths branch March 9, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when Downloading PDF in Ansible Credentials/Playbooks
4 participants