ProviderForeman - fix overriden list_row_id to return string id #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3530 By overriding `list_row_id` in ProviderForeman, it didn't get the `to_s` fix needed when moving from compressed ids to actual ids. Adding.
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/6872f0e0f05c9131e5dea635d04bb56abee5c3db with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Thanks @himdel for this fix, I am about to test it. I will update asap. |
|
@himdel It works for me, 👍 Thanks! ❇️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3530
By overriding
list_row_idin ProviderForeman, it didn't get theto_sfix needed when moving from compressed ids to actual ids, making it impossible to actually click a foreman manager in GTL.Adding :)
Cc @hstastna can you test please? :)