Fix for the infinte spinner on Playbook Catalog Item Edit Form Reset #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
@h-kataria - please review |
lgalis
force-pushed
the
reset_infinite_spinner_fix
branch
from
17b885e
to
e112af7
Compare
|
Checked commit lgalis@e112af7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lgalis Is this gaprindashvili/yes ? |
|
@mzazrivec - yes, I think the problem exists in gaprindashvili as well. @miq-bot add_label gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Mar 13, 2018
Fix for the infinte spinner on Playbook Catalog Item Edit Form Reset (cherry picked from commit e72ad4a) https://bugzilla.redhat.com/show_bug.cgi?id=1554823
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check for the data and stop the spinner when the Reset button is pressed on the Ansible Playbook Catalog Item edit form.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1553785
Steps for Testing/QA