New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable grid as view model for policy assignment screens #3554
Conversation
@miq-bot add_label bug |
Checked commit karelhala@4f90258 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@miq-bot add_label gaprindashvili/yes |
@dclarizio : what's your opinion on this one? I tried to describe the rules for GTL display mode here: https://github.com/ManageIQ/guides/blob/master/ui/gtl.md (at the bottom) So no matter what we decide, I want it documented for future reference ;-) |
@martinpovolny this was a grid before, just the GTL conversion happened. |
@martinpovolny the special case here is that this is for policy assignment, so the quadicon view (grid) shows the policy center image better than list view, which is why it was chosen for this display. It was noticed after GTL was refactored and it changed from grid to list. So, basically, what @skateman said. :) |
Ok, merged and documented. Thx! |
A last remark: what if the entity being assigned policies does not have a quadicon? Will everything still work? |
Enable grid as view model for policy assignment screens (cherry picked from commit ee309a8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561091
Gaprindashvili backport details:
|
Changes view type for policy assignment
When assigning policy for any items table (list) view is visible. This is not correct since we users expect quadicons. This PR fixes such issue adding
@gtl_type
to proctect method, same applies for explorer screens.UI changes
Before
After
BZ
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553071