Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable grid as view model for policy assignment screens #3554

Merged
merged 1 commit into from Mar 27, 2018

Conversation

karelhala
Copy link
Contributor

Changes view type for policy assignment

When assigning policy for any items table (list) view is visible. This is not correct since we users expect quadicons. This PR fixes such issue adding @gtl_type to proctect method, same applies for explorer screens.

UI changes

Before

screenshot from 2018-03-09 10-55-28

After

screenshot from 2018-03-09 10-53-28

BZ

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553071

@karelhala
Copy link
Contributor Author

@miq-bot add_label bug
@miq-bot assign @martinpovolny
@skateman is this going to be gaprindashvili/yes?

@miq-bot
Copy link
Member

miq-bot commented Mar 9, 2018

Checked commit karelhala@4f90258 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@skateman
Copy link
Member

skateman commented Mar 9, 2018

@miq-bot add_label gaprindashvili/yes

@martinpovolny
Copy link

martinpovolny commented Mar 25, 2018

@dclarizio : what's your opinion on this one?

I tried to describe the rules for GTL display mode here: https://github.com/ManageIQ/guides/blob/master/ui/gtl.md (at the bottom)

So no matter what we decide, I want it documented for future reference ;-)

@skateman
Copy link
Member

@martinpovolny this was a grid before, just the GTL conversion happened.

@dclarizio
Copy link

@martinpovolny the special case here is that this is for policy assignment, so the quadicon view (grid) shows the policy center image better than list view, which is why it was chosen for this display. It was noticed after GTL was refactored and it changed from grid to list. So, basically, what @skateman said. :)

@martinpovolny martinpovolny changed the title Enable grid as view model for policy assignemnt screens Enable grid as view model for policy assignment screens Mar 27, 2018
@martinpovolny martinpovolny merged commit ee309a8 into ManageIQ:master Mar 27, 2018
@martinpovolny
Copy link

Ok, merged and documented. Thx!

@martinpovolny
Copy link

A last remark: what if the entity being assigned policies does not have a quadicon? Will everything still work?

simaishi pushed a commit that referenced this pull request Mar 27, 2018
Enable grid as view model for policy assignment screens
(cherry picked from commit ee309a8)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561091
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit abd06e60edbfa13182fe4306b05633b4f79e517f
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Tue Mar 27 08:09:25 2018 +0200

    Merge pull request #3554 from karelhala/quadiconPolicies
    
    Enable grid as view model for policy assignment screens
    (cherry picked from commit ee309a81df70df7fe4299983e19423a526c64480)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants