Generic Object - fix extra vm.angularForm and nonused angularForm #3565
Conversation
main custom button form contains the actual form, does not get angularForm via bindings, so should not use vm custom image component *should* use vm, but the function does not actually take args
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/1d29a8442386f63f18936d0f6ff4a39173edaa3b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| @@ -19,7 +19,7 @@ | |||
| :title => t, | |||
| :alt => t, | |||
| :enabled => "true", | |||
| 'on-click' => "vm.uploadClicked(angularForm)"} | |||
| 'on-click' => "vm.uploadClicked()"} | |||
There was a problem hiding this comment.
Can't really call this a bug, since technically, nothing is broken w.r.t vm.uploadClicked right now, or nothing is getting fixed with this change.
| @@ -36,7 +36,7 @@ | |||
| = "<#{_('Choose')}>" | |||
| %span.help-block{"ng-show" => "angularForm.dialog_id.$error.required"} | |||
| = _("Required") | |||
| .form-group{"ng-class" => "{'has-error': vm.angularForm.display.$invalid}"} | |||
| .form-group{"ng-class" => "{'has-error': angularForm.display.$invalid}"} | |||
There was a problem hiding this comment.
although angularForm.display.$invalid is correct in this case, the error would never be exposed in this field which is a checkbox with Yes/No values - so technically, there is no "invalid" value here.
Anyway, good to have this change.
|
Above changes do not impact the forms in any way ...but are good to have - LGTM |
main custom button form contains the actual form, does not get angularForm via bindings, so should not use vm
custom image component should use vm, but the function does not actually take args
(noticed these while looking at network controllers, where
vm.angularFormis never right)Cc @AparnaKarve