Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CSP for webmks Console #3569

Merged
merged 1 commit into from Mar 13, 2018
Merged

Fixed CSP for webmks Console #3569

merged 1 commit into from Mar 13, 2018

Conversation

evertmulder
Copy link
Contributor

@evertmulder evertmulder commented Mar 10, 2018 •
edited by simaishi

Images from the webmks css causes CSP errors in browser console and evm.log
Was already fixed for HTML5 console (#2833)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558607

Fixed CSP for webmks Console
9d9ac65 
Images from the webmks css causes CSP errors in browser console and evm.log
@miq-bot
Copy link
Member

miq-bot commented Mar 10, 2018

Checked commit evertmulder@9d9ac65 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

app/controllers/vm_remote.rb

@mzazrivec mzazrivec self-assigned this Mar 13, 2018
@mzazrivec mzazrivec added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 13, 2018
@mzazrivec mzazrivec merged commit fadeca0 into ManageIQ:master Mar 13, 2018
@simaishi
Copy link
Contributor

@evertmulder Please add BZ link.

@evertmulder
Copy link
Contributor Author

@simaishi I think you BZ means bugzilla link? Sorry I have never used this...

@evertmulder evertmulder deleted the Fixed-CSP-for-WebMKS-Console branch March 13, 2018 20:25
@simaishi
Copy link
Contributor

@evertmulder Yes, that's what I meant 😄 But I took care of it, so no worry.

simaishi pushed a commit that referenced this pull request Mar 20, 2018
@mzazrivec @simaishi
Merge pull request #3569 from evertmulder/Fixed-CSP-for-WebMKS-Console
4fbe8f0 
Fixed CSP for webmks Console
(cherry picked from commit fadeca0)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558610
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 4fbe8f024b4f6e2363b1580dd18b4cdfaaab6f6a
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Mar 13 09:27:44 2018 +0100

    Merge pull request #3569 from evertmulder/Fixed-CSP-for-WebMKS-Console
    
    Fixed CSP for webmks Console
    (cherry picked from commit fadeca0b12018f4d7edbf605347bda30075cc610)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug consoles gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evertmulder @miq-bot @simaishi @mzazrivec