Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Cloud image tagging from a list #3612

Merged
merged 2 commits into from Mar 15, 2018
Merged

Fix for Cloud image tagging from a list #3612

merged 2 commits into from Mar 15, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Mar 13, 2018

Fix for Cloud image tagging from a list

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1501783

Steps for Testing/QA

  1. Select one Cloud Provider
  2. Display images and try tagging for a one or more selected ones

@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2018

@lgalis Cannot apply the following label because they are not recognized: gaprinashvili/yes

@miq-bot miq-bot added the bug label Mar 13, 2018
@lgalis
Copy link
Contributor Author

lgalis commented Mar 13, 2018

@miq-bot add_label gaprindashvili/yes

@mzazrivec
Copy link
Contributor

That Merge branch 'master' of github.com:ManageIQ/manageiq-ui-classic into… commit should not be part of this PR.

@miq-bot
Copy link
Member

miq-bot commented Mar 14, 2018

Checked commits lgalis/manageiq-ui-classic@1ed4406~...1469f38 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec self-assigned this Mar 15, 2018
@mzazrivec mzazrivec added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 15, 2018
@mzazrivec mzazrivec merged commit e5e181f into ManageIQ:master Mar 15, 2018
@lgalis lgalis deleted the cloud_image_tagging_fix branch March 15, 2018 13:08
simaishi pushed a commit that referenced this pull request Mar 16, 2018
@mzazrivec @simaishi
Merge pull request #3612 from lgalis/cloud_image_tagging_fix
f08199a 
Fix for Cloud image tagging from a list
(cherry picked from commit e5e181f)

https://bugzilla.redhat.com/show_bug.cgi?id=1557380
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit f08199a87c80fe84aebf931b64751a7df08003ef
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Mar 15 09:57:59 2018 +0100

    Merge pull request #3612 from lgalis/cloud_image_tagging_fix
    
    Fix for Cloud image tagging from a list
    (cherry picked from commit e5e181f11509e23f9396eb086b08599855987d46)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1557380

@simaishi
Copy link
Contributor

@lgalis Can this be fine/yes?

@lgalis
Copy link
Contributor Author

lgalis commented Apr 18, 2018

@simaishi - looks ok for a Fine backport

simaishi pushed a commit that referenced this pull request Apr 18, 2018
@mzazrivec @simaishi
Merge pull request #3612 from lgalis/cloud_image_tagging_fix
0a6cff7 
Fix for Cloud image tagging from a list
(cherry picked from commit e5e181f)

https://bugzilla.redhat.com/show_bug.cgi?id=1569241
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 0a6cff7fdc1f42c3ff9d67a31a3f976c9a3744a3
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Mar 15 09:57:59 2018 +0100

    Merge pull request #3612 from lgalis/cloud_image_tagging_fix
    
    Fix for Cloud image tagging from a list
    (cherry picked from commit e5e181f11509e23f9396eb086b08599855987d46)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1569241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug compute/cloud fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lgalis @miq-bot @mzazrivec @simaishi