Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace miqrequired with required #3613

Merged
merged 1 commit into from Mar 14, 2018
Merged

Replace miqrequired with required #3613

merged 1 commit into from Mar 14, 2018

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Mar 13, 2018 •
edited

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1554938

Steps to reproduce:

  • Configuration -> Settings -> Schedules ->Configuration -> Add new Schedule / Edit the selected Schedule
  • Select Automation Tasks as Action
  • See Request. It's requested only when editing.

Before:
image
After:
image

@miq-bot add_label gaprindashvili/yes, bug

@h-kataria please review, thanks :)

@ZitaNemeckova ZitaNemeckova mentioned this pull request Mar 13, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2018

Checked commit ZitaNemeckova@b5e472f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Mar 14, 2018
@mzazrivec mzazrivec added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 14, 2018
@mzazrivec mzazrivec merged commit 00f88f3 into ManageIQ:master Mar 14, 2018
simaishi pushed a commit that referenced this pull request Mar 16, 2018
@mzazrivec @simaishi
Merge pull request #3613 from ZitaNemeckova/replace_miqrequired
7ebe98b 
Replace miqrequired with required
(cherry picked from commit 00f88f3)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1557367
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 7ebe98b3fc947259af73b1947ab56dc153aba294
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Mar 14 09:48:41 2018 +0100

    Merge pull request #3613 from ZitaNemeckova/replace_miqrequired
    
    Replace miqrequired with required
    (cherry picked from commit 00f88f32c2777159906eb4c69119297b73c04dbf)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1557367

@himdel himdel mentioned this pull request Mar 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug gaprindashvili/backported settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZitaNemeckova @miq-bot @simaishi @mzazrivec