Define single_quad methods for each model decorator that has a quadicon #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits skateman/manageiq-ui-classic@248ea34~...6434a6b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
FYI @karelhala |
|
We should probably do a mixin for the default implementation at some point. But we can clean this up once the quadicon cleanup/refactoring is done :) Merging |
|
@himdel I agree, but let's switch to the new quads and fonticons (!!!) first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All quadicons can be rendered as a single-quad, so moving the definition of these quads into the decorators. In the future it will be possible to choose between
quadiconorsingle_quadbased on the user settings or what is available.@miq-bot add_label gtls, gaprindashvili/no