Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect RBAC rules for physical server quadicon settings #3625

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

skateman
Copy link
Member

When having a user without access to physical servers, it should not see the quadicon switch under My Settings.

Before:
screenshot from 2018-03-14 16-32-20

After:
screenshot from 2018-03-14 16-52-42

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1555400

@miq-bot add_label bug, gaprindashvili/yes

@mzazrivec mzazrivec self-assigned this Mar 15, 2018
@mzazrivec mzazrivec added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 15, 2018
@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2018

Checked commit skateman@a49ce99 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec mzazrivec merged commit e36308c into ManageIQ:master Mar 15, 2018
simaishi pushed a commit that referenced this pull request Mar 16, 2018
Respect RBAC rules for physical server quadicon settings
(cherry picked from commit e36308c)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1557400
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 4bb5f698aa7b8eb95f8d72b77d07b36b7896795d
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Mar 15 13:48:50 2018 +0100

    Merge pull request #3625 from skateman/physical-server-rbac-quad
    
    Respect RBAC rules for physical server quadicon settings
    (cherry picked from commit e36308c72b246ee9606f677bfb9837a31f9e1ffc)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1557400

@skateman skateman deleted the physical-server-rbac-quad branch September 7, 2018 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants