Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a column title for the Disk size Unit #3637

Merged
merged 1 commit into from Mar 19, 2018
Merged

Add a column title for the Disk size Unit #3637

merged 1 commit into from Mar 19, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Mar 15, 2018 •
edited

Add a header title for the Unit column

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1524960

Before:
screenshot from 2018-03-15 17-21-09

After:
screenshot from 2018-03-15 17-21-45

@lgalis
Copy link
Contributor Author

lgalis commented Mar 15, 2018

@miq_bot add_label bug

@lgalis lgalis force-pushed the reconfigure_disk_unit_column_title branch from 25c7dee to 6132e3d Compare March 16, 2018 14:21
@miq-bot
Copy link
Member

miq-bot commented Mar 16, 2018

Checked commit lgalis@6132e3d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec mzazrivec self-assigned this Mar 19, 2018
@mzazrivec mzazrivec added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 19, 2018
@mzazrivec mzazrivec merged commit 132e63d into ManageIQ:master Mar 19, 2018
@lgalis lgalis deleted the reconfigure_disk_unit_column_title branch March 19, 2018 12:48
simaishi pushed a commit that referenced this pull request Mar 19, 2018
@mzazrivec @simaishi
Merge pull request #3637 from lgalis/reconfigure_disk_unit_column_title
7e478af 
Add a column title for the Disk size Unit
(cherry picked from commit 132e63d)

https://bugzilla.redhat.com/show_bug.cgi?id=1558144
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 7e478afd4af033ee41be3143d110143b10dc740e
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Mar 19 09:56:26 2018 +0100

    Merge pull request #3637 from lgalis/reconfigure_disk_unit_column_title
    
    Add a column title for the Disk size Unit
    (cherry picked from commit 132e63d6b276ae04f891625706b9c1edc0e86c1e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1558144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug compute/infrastructure gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lgalis @miq-bot @simaishi @mzazrivec