Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message when trying to edit item with missing Provisioning request #3661

Merged

Conversation

h-kataria
Copy link
Contributor

Added check around code to prevent error when editing catalog item with missing Provisioning request, with this change, flash message will be displayed on the screen informing user that they can not proceed with editing selected catalog item because request is missing

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1476949
@lgalis please review/test, to test this, you will need to delete a provisioning request associated with a catalog item manually from your database.
@dclarizio please review

request_missing_fix

request_missing_msg_on_summary

Added check around code to prevent error when editing catalog item with missing Provisioning request, with this change, flash message will be displayed on the screen informing user that they can not proceed with editing selected catalog item because request is missing

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1476949
@h-kataria h-kataria force-pushed the catalog_item_missing_request_fix branch from acfad18 to 6a24e66 Compare March 20, 2018 21:36
@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2018

Checked commit h-kataria@6a24e66 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@dclarizio dclarizio merged commit 09b7417 into ManageIQ:master Mar 20, 2018
@dclarizio dclarizio added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 20, 2018
@simaishi
Copy link
Contributor

@h-kataria Can this be fine/yes ?

@h-kataria
Copy link
Contributor Author

@simaishi looks like it should be ok to backport this to Fine.

simaishi pushed a commit that referenced this pull request Mar 23, 2018
Show message when trying to edit item with missing Provisioning request
(cherry picked from commit 09b7417)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1560096
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit f1a1dfa8bdcb0768a2ad414ea1a19546250b3107
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Tue Mar 20 15:32:19 2018 -0700

    Merge pull request #3661 from h-kataria/catalog_item_missing_request_fix
    
    Show message when trying to edit item with missing Provisioning request
    (cherry picked from commit 09b7417c99f087c528caae02abb909186868e14d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1560096

@simaishi
Copy link
Contributor

@h-kataria There are conflicts backporting to Fine branch. Please create a separate PR.

@simaishi
Copy link
Contributor

Backported to Fine via #3746

@h-kataria h-kataria deleted the catalog_item_missing_request_fix branch April 16, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants