Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Schedule to have also custom MiqReport in Filter #3675

Merged
merged 1 commit into from Mar 26, 2018
Merged

Allow Schedule to have also custom MiqReport in Filter #3675

merged 1 commit into from Mar 26, 2018

Conversation

ZitaNemeckova
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1559323

Filter in Schedule form is missing custom MiqReports.

Cloud Intel -> Reports -> Schedules -> Configuration -> Edit/Add

Before:
image
After:
image

@miq-bot add_label bug, gaprindashvili/yes

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label cloud intel/reporting

@miq-bot
Copy link
Member

miq-bot commented Mar 23, 2018

Checked commit ZitaNemeckova@a2adb44 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Mar 26, 2018
@mzazrivec mzazrivec added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 26, 2018
@mzazrivec mzazrivec merged commit c724e6b into ManageIQ:master Mar 26, 2018
simaishi pushed a commit that referenced this pull request Mar 26, 2018
@mzazrivec @simaishi
Merge pull request #3675 from ZitaNemeckova/schedule_all_filters
30a1780 
Allow Schedule to have also custom MiqReport in Filter
(cherry picked from commit c724e6b)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1560708
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 30a17808227ab375f0382aba70bda692139b0dad
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Mar 26 15:39:24 2018 +0200

    Merge pull request #3675 from ZitaNemeckova/schedule_all_filters
    
    Allow Schedule to have also custom MiqReport in Filter
    (cherry picked from commit c724e6ba5ceee597b687f2101e1118a957dd48c5)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1560708

@yrudman
Copy link
Contributor

yrudman commented May 17, 2018

should this be backported to fine too?

@ZitaNemeckova
Copy link
Contributor Author

@yrudman Nope. It's ok in fine :) See here

@yrudman
Copy link
Contributor

yrudman commented May 17, 2018

@ZitaNemeckova last comment in https://bugzilla.redhat.com/show_bug.cgi?id=1559323
also, there is another BZ - https://bugzilla.redhat.com/show_bug.cgi?id=1554533: check Comment #4

@ZitaNemeckova
Copy link
Contributor Author

@yrudman You are right. Thanks :)

@miq-bot add_label fine/yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug gaprindashvili/backported overview/reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZitaNemeckova @miq-bot @simaishi @yrudman @mzazrivec