Allow scm_url to take ssh with ssh protocol #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540551 Allows http, https, ssh protocols. Allows ssh without protocol.
ZitaNemeckova
force-pushed
the
allow_ssh
branch
from
0db8ef7
to
109a93e
Compare
|
Checked commit ZitaNemeckova@109a93e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 2, 2018
Allow scm_url to take ssh with ssh protocol (cherry picked from commit 755efe4) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1562803
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540551
Allows http, https, ssh protocols. Allows ssh without protocol.
Automation -> Ansible -> Repositories -> Configuration -> Add/Edit Repository
Try something like
ssh://git@10.195.101.214:10022/jwong/awesome-pub.git.Before:
Only
https://<something>.<something>,http://<something>.<something>and<user>@<server>:<path>were allowed.After:
Allows also
ssh://git@<address>:<port><path>@miq-bot add_label bug, gaprindashvili/yes, automation/ansible