Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time profile form: make timezone select drop up (instead of drop down) #3703

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Mar 29, 2018

The selectbox being at the bottom of the page, there's not enough space for a dropdown select.

Before:
tp-before

After:
tp-after

@miq-bot
Copy link
Member

miq-bot commented Mar 29, 2018

Checked commit mzazrivec@17e34bd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@martinpovolny martinpovolny added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 6, 2018
@martinpovolny martinpovolny self-assigned this Apr 6, 2018
@martinpovolny martinpovolny merged commit 5261e6e into ManageIQ:master Apr 6, 2018
@mzazrivec mzazrivec deleted the timeprofile_make_timezone_selection_dropup branch April 6, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants