Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force expand active node in TreeBuilder #3708

Merged
merged 1 commit into from Apr 5, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Apr 3, 2018

The BZ below is a little bit complicated, a minimal reproducer is to navigate to Settings -> Access Control -> Users with a clean session and add a new user or edit an existing user's name. The changes will be affected on the right side, but not on the left.

The problem is that the expanded state of a lazily-loaded node isn't reflected until a full page reload. However, by navigating to the Users node the active node parameter is being set properly and this can be leveraged when setting the expanded state of the node itself.

@miq-bot add_reviewer @ZitaNemeckova
@miq-bot add_label gaprindashvili/yes, bug, trees

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1561698

@miq-bot
Copy link
Member

miq-bot commented Apr 3, 2018

Checked commit skateman@631afc7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@ZitaNemeckova
Copy link
Contributor

Configuration -> Access Control -> Users is not expanded -> click Users -> Configuration -> Add/Edit a User

Add new user
Before:
screen shot 2018-04-04 at 8 17 47 am
No Pepik user in left tree
After:
screen shot 2018-04-04 at 8 28 35 am
Namornik user in left tree

Edit a user
Before:
screen shot 2018-04-04 at 8 50 22 am
Pepek neni Namornik is not changed to Pepek Namornik in left tree
After:
screen shot 2018-04-04 at 8 56 52 am
Pepek neni Namornik is changed to Pepek neni Namornik in left tree

So LGTM 👍

Copy link
Contributor

@ZitaNemeckova ZitaNemeckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mzazrivec mzazrivec self-assigned this Apr 5, 2018
@mzazrivec mzazrivec merged commit def696f into ManageIQ:master Apr 5, 2018
@skateman skateman deleted the active-node-expanded branch April 5, 2018 08:44
@mzazrivec mzazrivec added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants