Restrict the Help->Documentation screen based on RBAC rules only #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@9aa897b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@skateman The BZ has cfme-5.8.z flag too.. Can this be |
|
@miq-bot add_label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 18, 2018
Restrict the Help->Documentation screen based on RBAC rules only (cherry picked from commit 7e2fffe) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1569171
|
Fine backport details: |
|
@skateman Can you take a look at Travis failure in File branch? I think that's coming from backport of this PR.... https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/368272457 |
simaishi
pushed a commit
that referenced
this pull request
Apr 19, 2018
Restrict the Help->Documentation screen based on RBAC rules only (cherry picked from commit 7e2fffe) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1569170
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation text is visible only for administrators even though the RBAC role can display the menu item for it. In this PR I'm dropping the
is_admin?calls from the view and introducing an RBAC check in the controller.@miq-bot add_label bug, gaprindashvili/yes
@miq-bot add_reviewer @romanblanco
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1563241