Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add direct redux npm dependency, redux 4.0.0 breaks #3790

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Add direct redux npm dependency, redux 4.0.0 breaks #3790

merged 1 commit into from
Apr 18, 2018

Commits on Apr 18, 2018

  1. Add direct redux npm dependency, redux 4.0.0 breaks 

    [Redux 4 is here!](https://github.com/reactjs/redux/releases) and [yarn is broken](https://gist.github.com/bdunne/c58ae9f3c26e6647f29392c6cfba7f2b) :(.

Turns out we only depend on redux indirectly, which means the redux 4.0.0 release broke the webpack build..

    ERROR in /home/bdunne/.gem/ruby/2.4.3/bundler/gems/manageiq-ui-classic-8303c278b9c0/node_modules/redux/index.d.ts
    (19,27): error TS1005: ',' expected.

    (and quite a bit more)

Adding that direct dependency.
Also removed @types/redux, since it has been [deprecated](https://www.npmjs.com/package/@types/redux).
    @himdel
    himdel committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    78d7bf2 View commit details
    Browse the repository at this point in the history