[FINE] Fixes display of confirmation message when deleting Saved Report #3849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
|
Checked commit GregP@8580aee with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@simaishi LGTM |
martinpovolny
approved these changes
Aug 8, 2018
There was a problem hiding this comment.
Based on @h-kataria 's LGTM, I am formally approving this one so that is shows as approved.
|
As per BZ target release, we're not fixing this in Fine branch. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes display of confirmation flash message when deleting singleton report on Saved Reports tab.
https://bugzilla.redhat.com/show_bug.cgi?id=1486639
Also, a duplicate with same issue: https://bugzilla.redhat.com/show_bug.cgi?id=1489387
Both apply only to FINE.
Screen shots prior to fix, first a single report listed in the tab. In this case, a new report was Queued. Actual condition for the non-display of confirmation flash message was tracked down to when ONLY one report is available for deletion, this screen shot shows creation of just one report as a set up for further delete report confirmation:
Single report deleted, no confirmation message, prior to code fix, just am info message for no reports to list:
Single report listed, post code fix:
Single report deleted post code fix, flash message display:
Report deleted from multi-report list, post code fix:
Deleted confirmation message display:
