Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of a dialog is required for a playbook catalog item #3926

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented May 10, 2018

Selection of a dialog is required for playbook catalog

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1574204

Make sure the issue in this BZ is also fixed, as I reverted the changes made in #3413.

Steps for Testing/QA

  1. Make sure a dialog is required when adding a Playbook Catalog Item
  2. Make sure the radio button for switching between a new and existing dialog is displayed when editing an existing catalog item.

After:
screenshot from 2018-05-11 09-15-31
screenshot from 2018-05-11 09-16-01

@miq-bot miq-bot added the wip label May 10, 2018
@lgalis lgalis force-pushed the dialog_flag_required_for_playbook_catalog branch from e10c80e to 9263437 Compare May 10, 2018 21:38
@lgalis
Copy link
Contributor Author

lgalis commented May 10, 2018

@miq_bot add_label bug

@lgalis lgalis force-pushed the dialog_flag_required_for_playbook_catalog branch from 9263437 to 7b7f01c Compare May 11, 2018 06:11
@miq-bot
Copy link
Member

miq-bot commented May 11, 2018

Checked commit lgalis@7b7f01c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@lgalis
Copy link
Contributor Author

lgalis commented May 11, 2018

@miq-bot add_label automation/ansible, gaprindashvili/yes
@h-kataria - please review

@lgalis lgalis changed the title [WIP] Selection of a dialog is required for a playbook catalog item Selection of a dialog is required for a playbook catalog item May 11, 2018
@lgalis
Copy link
Contributor Author

lgalis commented May 11, 2018

@miq-bot add_label bug

@miq-bot miq-bot added the bug label May 11, 2018
@JPrause
Copy link
Member

JPrause commented May 15, 2018

@miq-bot add_label blocker

@h-kataria h-kataria added this to the Sprint 86 Ending May 21, 2018 milestone May 15, 2018
@h-kataria h-kataria merged commit 8c5aca4 into ManageIQ:master May 15, 2018
simaishi pushed a commit that referenced this pull request May 16, 2018
…k_catalog

Selection of a dialog is required for a playbook catalog item
(cherry picked from commit 8c5aca4)

https://bugzilla.redhat.com/show_bug.cgi?id=1578976
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 7d5f48c7e6eb5a7e8179aef76d1eed7a1b8b7b6b
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue May 15 14:34:51 2018 -0400

    Merge pull request #3926 from lgalis/dialog_flag_required_for_playbook_catalog
    
    Selection of a dialog is required for a playbook catalog item
    (cherry picked from commit 8c5aca41a689726ae663dde144a76a67852c98e2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1578976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants