Change text color to blue for different columns when displaying Drift for VM #3938
Conversation
hstastna
changed the title
|
@dclarizio This PR is related to one of the issues you were talking about, when talking about Drifts and VMs with me ;) What do you think about it? |
hstastna
force-pushed
the
Drift_diff_color_blue
branch
2 times, most recently
from
039e513
to
9b54973
Compare
| def drift_add_txt_col(idx, col, img_bkg) | ||
| html_text = "<div class='#{img_bkg}'>#{col}</div>" | ||
| def drift_add_txt_col(idx, col, img_bkg, style = nil) | ||
| html_text = if style.present? |
| if idx.zero? # On base object | ||
| img_bkg = "cell-stripe" | ||
| elsif fld[:_match_] | ||
| img_bkg = "cell-bkg-plain-no-shade" | ||
| else | ||
| style = "color: #21a0ec;" if fld[:_match_] == false |
There was a problem hiding this comment.
Here we want to set style ONLY when there IS _match_ key and if it is set to false. Often, fld looks like this: {:_value_=>"(empty)"}, and then if I used unless fld[:_match_], style would be set, and we don't want this in this case. So I better used condition in format if fld[:_match_] == false, to make sure that the style is set really only when we want it. Fortunatelly, when fld has no _match_ key, idx is usually zero so it will not enter the else part of the block and nothing bad should happen, in fact. But I don't want to rely on this (on the fact that idx is checked before checking fld).
| @@ -1208,15 +1208,17 @@ def drift_add_section_field_expanded(view, section, field) | |||
| next if fld.nil? | |||
| val = fld[:_value_].to_s | |||
|
|
|||
| style = nil | |||
hstastna
force-pushed
the
Drift_diff_color_blue
branch
from
9b54973
to
e86a108
Compare
|
Checked commit hstastna@e86a108 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Before:
After:
