Restrict quadicon class demodulization for Physical* records only #3980
Conversation
|
@skateman 'saulotoledo' is an invalid reviewer, ignoring... |
|
Thank you for adding me here, @skateman ! @epwinchell, I agree with the fix. There is already another change in the Physical Switches model that can help here. We just need to have the following PRs approved:
I am not sure about how much time we need to aprove them, but if this PR is approved before I can ask @EsdrasVP to do the refactoring (i.e. remove the lines added here) in that code. |
| @@ -70,7 +70,7 @@ def self.settings_key(klass, layout) | |||
| when "ems_physical_infra", "ems_cloud", "ems_network", "ems_container" | |||
| layout.to_sym | |||
| end | |||
| elsif klass.base_model.name != klass.name.demodulize | |||
| elsif klass.name.demodulize.starts_with?("Physical") && klass.base_model.name != klass.name.demodulize | |||
There was a problem hiding this comment.
I agree with that if we remove later at #3954
There is a dependency in the core there. So the current PR can be approved faster.
skateman
force-pushed
the
physical-quad-fix
branch
from
eb6b583
to
ce857b1
Compare
|
Checked commits skateman/manageiq-ui-classic@931f94a~...ce857b1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
The demodulization introduced by @saulotoledo breaks the quadicon settings key selection for templates. By restricting the demodulization to the models starting with
Physicalthis issue can be solved easily. However, the whole quadicon settings key logic should be refactored in the future.Before:
After:
@miq-bot add_label bug, gtls, gaprindashvili/no
@miq-bot add_reviewer @epwinchell